-
Notifications
You must be signed in to change notification settings - Fork 635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Synchronous gauge prototype #3462
Synchronous gauge prototype #3462
Conversation
Well done! ✌️ |
What's the status on this? I would very much like to get my hands on the synchronous gauge API. |
@sarafonseca-123 Why did you make |
Oh, because it's experimental? I only just now saw that in the resolved comments. |
185cc0d
to
87e5a4c
Compare
Pull Request is not mergeable
8426501
to
0549d48
Compare
Pull Request is not mergeable
Pull Request is not mergeable
The only thing missing here seems to be one leftover reference in the docs to |
Co-authored-by: Diego Hurtado <ocelotl@users.noreply.github.com>
85c9e37
to
50193fb
Compare
Description
This PR creates a synchronous gauge instrument, based on opentelemetry-java PR Add experimental synchronous gauge #5506. It aims to give support to synchronous gauge as stated on opentelemetry-specification PR Add synchronous gauge instrument, clarify temporality selection influence on metric point persistence #3540.
Fixes # (issue)
#3363
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
This change was tested with multiple unit tests, that were contributed.
Also, it was locally tested with a simple API in Flask integrating with an OTEL server deployed on Kubernetes, using Python 3.8.
Does This PR Require a Contrib Repo Change?
Answer the following question based on these examples of changes that would require a Contrib Repo Change:
The OTel specification has changed which prompted this PR to update the method interfaces of
opentelemetry-api/
oropentelemetry-sdk/
The method interfaces of
test/util
have changedScripts in
scripts/
that were copied over to the Contrib repo have changedConfiguration files that were copied over to the Contrib repo have changed (when consistency between repositories is applicable) such as in
pyproject.toml
isort.cfg
.flake8
When a new
.github/CODEOWNER
is addedMajor changes to project information, such as in:
README.md
CONTRIBUTING.md
Yes. - Link to PR:
No.
Checklist: