Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stack trace on StatusCode.UNKNOWN export error #3536

Merged
merged 3 commits into from
Nov 22, 2023

Conversation

jakewins
Copy link
Contributor

Description

A deployment I ran over the weekend is logging the following message hundreds of times per minute:

"Failed to export metrics to otlp.eu01.nr-data.net, error code: StatusCode.UNKNOWN"

For this status code - 'Unknown' - it would be nice to have the full error logged, as the message above is very hard to debug.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

I've added a unit test, test_unknown_logs, but haven't been able to run it, because I'm struggling a bit with how to set up this project for development.

If this patchset seems useful to include, I'm happy to invest some time to get the test sorted properly. I asked in the slack channel for some help with how people normally set up the project for development.

Does This PR Require a Contrib Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@jakewins jakewins requested a review from a team November 20, 2023 11:40
Copy link
Contributor

@lzchen lzchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a changelog entry

jakewins added a commit to jakewins/opentelemetry-python that referenced this pull request Nov 22, 2023
A deployment I ran over the weekend is logging the following message
hundreds of times per minute:

> "Failed to export metrics to otlp.eu01.nr-data.net, error code: StatusCode.UNKNOWN"

For this status code - 'Unknown' - it would be nice to have the full
error logged, as the message above is very hard to debug.
@jakewins
Copy link
Contributor Author

@lzchen done!

@lzchen lzchen merged commit f399195 into open-telemetry:main Nov 22, 2023
111 checks passed
@jakewins jakewins deleted the jake/exc-info-unknown-export branch November 22, 2023 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants