Remove 'backoff' dependency and use a function instead #3679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmcollins
force-pushed
the
backoff
branch
3 times, most recently
from
7a0a059
to
7b48824
Compare
sfc-gh-bdrutu
approved these changes
Feb 9, 2024
bogdandrutu
approved these changes
Feb 9, 2024
ocelotl
suggested changes
Feb 12, 2024
exporter/opentelemetry-exporter-otlp-proto-common/tests/test_backoff.py
Outdated
Show resolved
Hide resolved
ocelotl
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The backoff dependency doesn't appear to have been needed as used, and it has caused at least one reported dependency conflict for an OTel Python user/developer. This change removes the dependency and replaces it with a function.
Fixes #3680