Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing ABC for Metric #391

Merged
merged 1 commit into from
Jan 31, 2020
Merged

Add missing ABC for Metric #391

merged 1 commit into from
Jan 31, 2020

Conversation

GoPavel
Copy link
Contributor

@GoPavel GoPavel commented Jan 31, 2020

Fixes #390

@GoPavel GoPavel requested a review from a team January 31, 2020 10:34
@codecov-io
Copy link

codecov-io commented Jan 31, 2020 •
edited
Loading

Codecov Report

Merging #391 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #391      +/-   ##
==========================================
+ Coverage   85.32%   85.33%   +<.01%     
==========================================
  Files          38       38              
  Lines        1929     1930       +1     
  Branches      227      227              
==========================================
+ Hits         1646     1647       +1     
  Misses        218      218              
  Partials       65       65
Impacted Files Coverage Δ
...elemetry-api/src/opentelemetry/metrics/__init__.py 88.13% <100%> (+0.2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 682ecc2...bab7d57. Read the comment docs.

codeboten
codeboten approved these changes Jan 31, 2020
View reviewed changes
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! The change looks good, you'll just need to sign the CLA and it will be good to go.

@GoPavel
Copy link
Contributor Author

GoPavel commented Jan 31, 2020

I signed it

@hectorhdzg hectorhdzg added the PR:please merge This PR is ready to be merged by a Maintainer (has enough valid approvals, successful build, etc.) label Jan 31, 2020
@toumorokoshi toumorokoshi merged commit 27f04b6 into open-telemetry:master Jan 31, 2020
@toumorokoshi
Copy link
Member

Great, thanks!

@GoPavel GoPavel deleted the patch-1 branch February 2, 2020 11:34
toumorokoshi pushed a commit to toumorokoshi/opentelemetry-python that referenced this pull request Feb 17, 2020
@GoPavel @toumorokoshi
Add missing ABC for Metric (open-telemetry#391)
0f96e19 
Fix open-telemetry#390
srikanthccv pushed a commit to srikanthccv/opentelemetry-python that referenced this pull request Nov 1, 2020
@OlivierAlbertini @mayurkale22
refactor(plugin-http): remove utility class container (open-telemetry…
9d9691f 
…#391)

closes open-telemetry#345

Signed-off-by: Olivier Albertini <olivier.albertini@montreal.ca>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ocelotl ocelotl ocelotl approved these changes

@codeboten codeboten codeboten approved these changes

Assignees
No one assigned
Labels
PR:please merge This PR is ready to be merged by a Maintainer (has enough valid approvals, successful build, etc.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing ABC for Metric
6 participants
@GoPavel @codecov-io @toumorokoshi @codeboten @ocelotl @hectorhdzg