-
Notifications
You must be signed in to change notification settings - Fork 635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
flask-debug-3933: update to set debug explicitly to False #3956
flask-debug-3933: update to set debug explicitly to False #3956
Conversation
Signed-off-by: Kroeger, Keith <keith.kroeger@fmr.com>
Signed-off-by: keithkroeger <10414523+keithkroeger@users.noreply.github.com>
Signed-off-by: keithkroeger <10414523+keithkroeger@users.noreply.github.com>
Signed-off-by: keithkroeger <10414523+keithkroeger@users.noreply.github.com>
Co-authored-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com>
@keithkroeger please fix conflict and next time please leave enabled the ability for maintainers to update your pr. Thanks! |
@keithkroeger ping, let's get this merged |
I'm not authorized to merge but appreciate it if you can |
Unfortunately everytime a different change is merged in, you will have to rebase and resolve any conflicts. If you change the pr to allow for one of the maintainers to fix the conflicts for you, you won't have to come back everytime for you to get this merged. I advise changing the permissions or creating a new PR, we can't hold off merging other prs. |
Head branch was pushed to by a user without write access
Thank you. Is there any way to allow auto merge? |
I have enabled auto merge, I'm not sure if this will merge this PR automatically, because I have seen it disable itself as tests are being run. Does this help? |
@keithkroeger I don't think closing and reopening is helpful |
|
Hi @xrmx, @lzchen, and @ocelotl, thanks for your help merging this. I think I can help with some context on the request to allow maintainers to edit. Unfortunately that setting is only available for personal forks, and it isn't available when a repo is forked into an org (as is the case with our contributions). It means the responsibility will be on our contributors to keep things as up-to-date as possible. I'm sorry if it created difficulties here. We'll do our best to be responsive about keeping branches updated while they're in flight. |
Description
Change so that flask does not run in debug mode.
Fixes #3933
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Executed test suite