-
Notifications
You must be signed in to change notification settings - Fork 635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix _encode_events assumes events.attributes.dropped exists #3965
Conversation
All the tests say "GitHub Actions has encountered an internal error when running your job.". Is there some issue with it? |
...roto-common/src/opentelemetry/exporter/otlp/proto/common/_internal/trace_encoder/__init__.py
Show resolved
Hide resolved
@soumyadeepm04, could you please add a changelog entry? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test failed is the annoyingtest_batch_span_processor_scheduled_delay
. We skipped it for PyPy + Windows here #3938, but it seems also have problems in other jobs on Windows
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On a separate note, should we have typing info for self._attributes to indicate Union[Attributes, BoundedAttributes]
?
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
created a dropped_attributes property in Events similar to ReadableSpan.
Fixes #3761
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
created an event object and tested it locally.
Does This PR Require a Contrib Repo Change?
Answer the following question based on these examples of changes that would require a Contrib Repo Change:
The OTel specification has changed which prompted this PR to update the method interfaces of
opentelemetry-api/
oropentelemetry-sdk/
The method interfaces of
test/util
have changedScripts in
scripts/
that were copied over to the Contrib repo have changedConfiguration files that were copied over to the Contrib repo have changed (when consistency between repositories is applicable) such as in
pyproject.toml
isort.cfg
.flake8
When a new
.github/CODEOWNER
is addedMajor changes to project information, such as in:
README.md
CONTRIBUTING.md
Yes. - Link to PR:
No.
Checklist: