Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix _encode_events assumes events.attributes.dropped exists #3965

Merged
merged 11 commits into from
Jun 20, 2024

Conversation

soumyadeepm04
Copy link
Contributor

@soumyadeepm04 soumyadeepm04 commented Jun 11, 2024

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
created a dropped_attributes property in Events similar to ReadableSpan.

Fixes #3761

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

created an event object and tested it locally.

Does This PR Require a Contrib Repo Change?

Answer the following question based on these examples of changes that would require a Contrib Repo Change:

  • The OTel specification has changed which prompted this PR to update the method interfaces of opentelemetry-api/ or opentelemetry-sdk/

  • The method interfaces of test/util have changed

  • Scripts in scripts/ that were copied over to the Contrib repo have changed

  • Configuration files that were copied over to the Contrib repo have changed (when consistency between repositories is applicable) such as in

    • pyproject.toml
    • isort.cfg
    • .flake8
  • When a new .github/CODEOWNER is added

  • Major changes to project information, such as in:

    • README.md
    • CONTRIBUTING.md
  • Yes. - Link to PR:

  • No.

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@soumyadeepm04 soumyadeepm04 requested a review from a team June 11, 2024 20:26
@soumyadeepm04 soumyadeepm04 marked this pull request as draft June 11, 2024 20:35
@soumyadeepm04 soumyadeepm04 marked this pull request as ready for review June 11, 2024 20:54
@soumyadeepm04
Copy link
Contributor Author

All the tests say "GitHub Actions has encountered an internal error when running your job.". Is there some issue with it?

@emdneto
Copy link
Member

emdneto commented Jun 13, 2024

@soumyadeepm04, could you please add a changelog entry?

@soumyadeepm04 soumyadeepm04 changed the title fix _encode_events assuming events.attributes.dropped exists fix _encode_events assumes events.attributes.dropped exists Jun 13, 2024
Copy link
Member

@emdneto emdneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test failed is the annoyingtest_batch_span_processor_scheduled_delay. We skipped it for PyPy + Windows here #3938, but it seems also have problems in other jobs on Windows

Copy link
Contributor

@lzchen lzchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On a separate note, should we have typing info for self._attributes to indicate Union[Attributes, BoundedAttributes]?

@ocelotl ocelotl merged commit 754fc36 into open-telemetry:main Jun 20, 2024
269 checks passed
@soumyadeepm04 soumyadeepm04 deleted the workbranch branch June 21, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

_encode_events assumes that event.attributes.dropped exists
5 participants