Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to type bytes for OTLP AnyValue encoding #4128

Merged
merged 8 commits into from
Aug 28, 2024

Conversation

wasup-yash
Copy link
Contributor

@wasup-yash wasup-yash commented Aug 16, 2024

Description

Fixes #4118

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A

Does This PR Require a Contrib Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

Copy link

linux-foundation-easycla bot commented Aug 16, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

@wasup-yash
Copy link
Contributor Author

@lzchen tagging for the review if good then can proceed to merge

Copy link
Member

@emdneto emdneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Care to add a changelog entry and update an existing test or add a new one?

@emdneto emdneto changed the title updated for bytes Add support to type bytes for OTLP AnyValue encoding Aug 16, 2024
@wasup-yash
Copy link
Contributor Author

Thanks. Care to add a changelog entry and update an existing test or add a new one?

did the entry part, but couldn't find the test specifically for the encoding part, can you point me to exactly where are we testing for the encoding formats?

@lzchen
Copy link
Contributor

lzchen commented Aug 16, 2024

@wasup-yash

Please mark this as PR if it is ready to review.

@wasup-yash wasup-yash marked this pull request as ready for review August 17, 2024 00:38
@wasup-yash wasup-yash requested a review from a team August 17, 2024 00:38
@wasup-yash
Copy link
Contributor Author

@wasup-yash

Please mark this as PR if it is ready to review.

done

@lzchen
Copy link
Contributor

lzchen commented Aug 19, 2024

@wasup-yash

You can either add a new file here creating a test suite to just test encode_value or you can add to the existing encode_attributes test suit to include these uses cases.

Signed-off-by: wasup-yash <trooper0018080@gmail.com>
Signed-off-by: wasup-yash <trooper0018080@gmail.com>
@wasup-yash
Copy link
Contributor Author

what could be the reason tests are failing, is it cause the tests are not written correctly? (I am not familiar with the tests written in Python so If anyone can suggest what needs to be done here )

@lzchen
Copy link
Contributor

lzchen commented Aug 20, 2024

@wasup-yash

Left a comment on how to fix your test.

Also, please add a CHANGELOG entry.

Signed-off-by: wasup-yash <trooper0018080@gmail.com>
@xrmx
Copy link
Contributor

xrmx commented Aug 21, 2024

@wasup-yash Need to run black over your changes and add a CHANGELOG entry, I suggest to setup pre-commit as in CONTRIBUTING.md to have it done automatically at commit time.

@wasup-yash
Copy link
Contributor Author

Need to run black over your changes

what does it mean though , understood the pre-commit part though

Copy link
Contributor

@zhihali zhihali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

About the black and the isort, check the contribution.md here

`black` and `isort` are executed when `tox -e lint` is run. The reported errors can be tedious to fix manually.

and about the changelog entry, you can refer to some merged PR, how they write the changelog. A randome example: #4122

Signed-off-by: wasup-yash <trooper0018080@gmail.com>
@wasup-yash
Copy link
Contributor Author

Do I have to run pre-commit run --all-files and then commit the changes as there were a lot of changes ? cause this time I did just only , a pre-commit install and then committed the changelog.md and there were 3 skipped files by pre-commit that was it :)

CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Emídio Neto <9735060+emdneto@users.noreply.github.com>
@lzchen lzchen merged commit 15ea441 into open-telemetry:main Aug 28, 2024
376 checks passed
@wasup-yash wasup-yash deleted the dev branch August 28, 2024 18:08
hyoinandout pushed a commit to hyoinandout/opentelemetry-python that referenced this pull request Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support type bytes for OTLP AnyValue encoding
5 participants