Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add log formatting support #4166

Merged
merged 2 commits into from
Sep 4, 2024
Merged

Conversation

jeremydvoss
Copy link
Contributor

@jeremydvoss jeremydvoss commented Aug 29, 2024

Description

Based off #3673 while maintaining existing Exception bodies and support for non-str message types.

Fixes #3664
Related to #3353

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Added new tests

Does This PR Require a Contrib Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@jeremydvoss jeremydvoss force-pushed the log-format branch 4 times, most recently from 7d7d337 to b47ca63 Compare August 29, 2024 23:34
@jeremydvoss jeremydvoss force-pushed the log-format branch 6 times, most recently from 444cd73 to 91affe4 Compare August 30, 2024 19:10
@jeremydvoss jeremydvoss marked this pull request as ready for review September 3, 2024 21:44
@jeremydvoss jeremydvoss requested a review from a team September 3, 2024 21:44
@lzchen lzchen merged commit e6486be into open-telemetry:main Sep 4, 2024
376 checks passed
@jeremydvoss
Copy link
Contributor Author

Can we close #3673 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

opentelemetry.sdk._logs.LoggingHandler doesn't format
3 participants