Add log formatting support #4166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremydvoss
force-pushed
the
log-format
branch
4 times, most recently
from
7d7d337
to
b47ca63
Compare
jeremydvoss
force-pushed
the
log-format
branch
6 times, most recently
from
444cd73
to
91affe4
Compare
jeremydvoss
force-pushed
the
log-format
branch
from
91affe4
to
59f2d46
Compare
xrmx
approved these changes
Sep 4, 2024
lzchen
approved these changes
Sep 4, 2024
8 tasks
|
Can we close #3673 ? |
This was referenced Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Based off #3673 while maintaining existing Exception bodies and support for non-str message types.
Fixes #3664
Related to #3353
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Added new tests
Does This PR Require a Contrib Repo Change?
Checklist: