Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc isort fixes #535

Merged
merged 3 commits into from
Mar 30, 2020
Merged

Misc isort fixes #535

merged 3 commits into from
Mar 30, 2020

Conversation

c24t
Copy link
Member

@c24t c24t commented Mar 30, 2020

I noticed that isort --recursive . didn't pass on master while working on some unrelated changes.

isort also sorted psutil as a first-party import in docs/examples/basic_meter/observer.py for me.

@c24t c24t requested a review from a team March 30, 2020 21:10
Copy link
Member

@toumorokoshi toumorokoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@codecov-io
Copy link

codecov-io commented Mar 30, 2020

Codecov Report

Merging #535 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #535   +/-   ##
=======================================
  Coverage   89.64%   89.64%           
=======================================
  Files          43       43           
  Lines        2240     2240           
  Branches      248      248           
=======================================
  Hits         2008     2008           
  Misses        159      159           
  Partials       73       73           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28ee03f...325cdea. Read the comment docs.

Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@c24t c24t merged commit 9320cfe into open-telemetry:master Mar 30, 2020
@c24t c24t deleted the isort-fixes branch March 30, 2020 23:00
c24t added a commit to c24t/opentelemetry-python that referenced this pull request Mar 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants