Rename Measure to ValueRecorder #761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codeboten
approved these changes
Jun 1, 2020
c24t
approved these changes
Jun 2, 2020
Comment on lines
-27
to
-31
| .. versionadded:: 0.1.0 | ||
| .. versionchanged:: 0.5.0 | ||
| ``meter_provider`` was replaced by `get_meter_provider`, | ||
| ``set_preferred_meter_provider_implementation`` was replaced by | ||
| `set_meter_provider`. |
There was a problem hiding this comment.
It may well make sense to lose the version comments until we're out of beta, but why do it in this PR?
There was a problem hiding this comment.
CHANGELOG.md contains a lot more information than the version comments (some missed API changes related to metrics). Instead of updating in multiple places, we can just refer to that file.
toumorokoshi
pushed a commit
to toumorokoshi/opentelemetry-python
that referenced
this pull request
Jun 5, 2020
sethmaxwl
pushed a commit
to sethmaxwl/opentelemetry-python
that referenced
this pull request
Jun 5, 2020
srikanthccv
pushed a commit
to srikanthccv/opentelemetry-python
that referenced
this pull request
Nov 1, 2020
* fix: update web examples to use WebTracerRegistry closes open-telemetry#756 * fix: renamed WebTracerRegistry to WebTracerProvider
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of [#752].
Simple name change.