fix: add exceptions to sinatra spans. #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scbjans
requested review from
fbogsany,
mwear,
robertlaurin,
dazuma,
ericmustin,
arielvalentin,
ahayworth,
plantfansam and
robbkidd
as code owners
|
edit: the screenshot is not accurate anymore; as of now a span is marked as in error with addition of the exception to the span whenever it has a server error, HTTP > 500 |
arielvalentin
requested changes
Oct 3, 2022
...mentation/sinatra/lib/opentelemetry/instrumentation/sinatra/middlewares/tracer_middleware.rb
Outdated
Show resolved
Hide resolved
instrumentation/sinatra/test/opentelemetry/instrumentation/sinatra_test.rb
Outdated
Show resolved
Hide resolved
instrumentation/sinatra/test/opentelemetry/instrumentation/sinatra_test.rb
Outdated
Show resolved
Hide resolved
...mentation/sinatra/lib/opentelemetry/instrumentation/sinatra/middlewares/tracer_middleware.rb
Show resolved
Hide resolved
arielvalentin
approved these changes
Oct 4, 2022
…atra_test.rb Co-authored-by: Ariel Valentin <arielvalentin@users.noreply.github.com>
…atra_test.rb Co-authored-by: Ariel Valentin <arielvalentin@users.noreply.github.com>
…s/opentelemetry-ruby-contrib into 56-add-sinatra-exceptions
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will add any caught Sinatra exceptions to the Span.
Fixes: #56
(edit: updated screenshot so that it correctly reflects outcome of this PR: only server side errors will mark a span as in error and attach an exception to the span.)
