Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export Resources from Jaeger exporter #314

Closed
mwear opened this issue Aug 10, 2020 · 3 comments · Fixed by #348
Closed

Export Resources from Jaeger exporter #314

mwear opened this issue Aug 10, 2020 · 3 comments · Fixed by #348
Assignees
Milestone

Comments

@mwear
Copy link
Member

mwear commented Aug 10, 2020

The Jaeger exporter does not currently export Resources. It comes close to exporting them as process tags here.

This is somewhat more complicated than it should be, because the specification allows for multiple tracer providers, where each can have different resources, but be hooked up to the same export pipeline. See here for more commentary. If we follow the spec, resources do not necessarily have a 1-1 relationship with processes, and that makes it difficult to add resource labels as Jaeger process tags.

We have two options (possibly more) that we can consider:

@genebean
Copy link
Contributor

For what it’s worth, I like the idea of being consistent across languages. With that in mind, merge resource labels into span attributes makes sense to me.

@fbogsany
Copy link
Contributor

The collector adds resource tags as process tags rather than merging them into span attributes: https://github.com/open-telemetry/opentelemetry-collector/blob/cadd49875b3bcbc6ca555b66c7d09b6d3a78bff0/translator/trace/jaeger/traces_to_jaegerproto.go#L107-L133

I think this approach makes more sense. If we're going to support multiple tracer providers, we should group spans for export by Resource and export each group as a batch with the Resource encoded as the process.

@mwear
Copy link
Member Author

mwear commented Aug 21, 2020

I'm flexible about how we solve this, but think that we should aim for consistency across languages. I opened a spec issue for discussion: open-telemetry/opentelemetry-specification#848.

@fbogsany fbogsany added this to the Alpha v0.6 milestone Aug 27, 2020
@mwear mwear self-assigned this Aug 28, 2020
@mwear mwear linked a pull request Aug 28, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants