Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define resource mapping for Jaeger export #848

Closed
mwear opened this issue Aug 21, 2020 · 2 comments · Fixed by #891
Closed

Define resource mapping for Jaeger export #848

mwear opened this issue Aug 21, 2020 · 2 comments · Fixed by #891
Labels
area:sdk Related to the SDK priority:p3 Lowest priority level release:required-for-ga Must be resolved before GA release, or nice to have before GA spec:trace Related to the specification/trace directory

Comments

@mwear
Copy link
Member

mwear commented Aug 21, 2020

What are you trying to achieve?

Mapping Resources to Jaeger is not straightforward due to the multiple tracer provider use case, see: https://github.com/open-telemetry/opentelemetry-specification/blob/master/specification/trace/api.md#tracerprovider. Ideally they would map to Jaeger process tags, however, since two tracer providers can have separate resources, but share the same exporter, an
exporter has to assume that spans are coming from multiple resources. I can see a couple of ways to handle this:

Post per resource: An exporter can group spans by resource, make separate posts for each resource, and map the resource to process tags.

Merge Resource Attributes with Span Attributes: Avoid the multiple resource issue by merging resource attributes with span attributes. This would have to be done for each span.

We could consider re-evaluating the multiple tracer provider use case. It leads to a number of other, similar complications.

Additional context.

Both Python and Go have solved this by merging Resource attributes with Span attributes. See:

We should decide how to handle this and document the decision in the jaeger spec

@mwear mwear added the spec:trace Related to the specification/trace directory label Aug 21, 2020
@andrewhsu andrewhsu added priority:p3 Lowest priority level release:required-for-ga Must be resolved before GA release, or nice to have before GA area:sdk Related to the SDK labels Aug 21, 2020
@mwear
Copy link
Member Author

mwear commented Aug 25, 2020

I wanted to add that this is a consequence of design decisions described in this comment: #508 (comment).

@mwear
Copy link
Member Author

mwear commented Aug 26, 2020

We discussed this during the spec SIG on Tuesday and decided that Resources should be exported as Jaeger process tags. This is what the collector does. See: https://github.com/open-telemetry/opentelemetry-collector/blob/cadd49875b3bcbc6ca555b66c7d09b6d3a78bff0/translator/trace/jaeger/traces_to_jaegerproto.go#L107-L133

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:sdk Related to the SDK priority:p3 Lowest priority level release:required-for-ga Must be resolved before GA release, or nice to have before GA spec:trace Related to the specification/trace directory
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants