-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc(redis instrumentation): Use latest options in readme #1058
doc(redis instrumentation): Use latest options in readme #1058
Conversation
instrumentation/redis/README.md
Outdated
@@ -47,8 +47,8 @@ end | |||
OpenTelemetry::SDK.configure do |c| | |||
c.use 'OpenTelemetry::Instrumentation::Redis', { | |||
# The obfuscation of arguments in the db.statement attribute is enabled by default. | |||
# To disable, set enable_statement_obfuscation to false. | |||
enable_statement_obfuscation: true, | |||
# To disable, set db_statement to :include or :omit if the tag not required. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Obfuscate is also a valid and supported option.
# To disable, set db_statement to :include or :omit if the tag not required. | |
# To disable, set db_statement to :include, :obfuscate or :omit if the tag not required. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A bit rephrased the comment - I split options to separate lines.
There is no option `enable_statement_obfuscation` for `OpenTelemetry::Instrumentation::Redis`. Replace example with option `db_statement` in README.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @miry
There is no option
enable_statement_obfuscation
forOpenTelemetry::Instrumentation::Redis
.Replace example with option
db_statement
in README.