Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: XRay propagator null exception #833

Merged
merged 3 commits into from
Jun 24, 2021
Merged

Fix: XRay propagator null exception #833

merged 3 commits into from
Jun 24, 2021

Conversation

scar-lovevery
Copy link
Contributor

This is in reference to:
#832

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jun 23, 2021 •
edited
Loading

CLA Signed

The committers are authorized under a signed CLA.

ahayworth
ahayworth approved these changes Jun 23, 2021
View reviewed changes
Copy link
Contributor

@ahayworth ahayworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - is it possible to add a quick test case for this too?

@scar-lovevery
Copy link
Contributor Author

Added a test.

robertlaurin
robertlaurin approved these changes Jun 23, 2021
View reviewed changes
Copy link
Contributor

@robertlaurin robertlaurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, you will need to sign the CLA before I can merge it in though.

@scar-lovevery
Copy link
Contributor Author

Done.

@fbogsany fbogsany merged commit 42fa792 into open-telemetry:main Jun 24, 2021
@github-actions github-actions bot mentioned this pull request Jun 24, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertlaurin robertlaurin robertlaurin approved these changes

@ahayworth ahayworth ahayworth approved these changes

@fbogsany fbogsany fbogsany approved these changes

@arielvalentin arielvalentin Awaiting requested review from arielvalentin arielvalentin is a code owner

@dazuma dazuma Awaiting requested review from dazuma dazuma is a code owner

@ericmustin ericmustin Awaiting requested review from ericmustin ericmustin is a code owner

@mwear mwear Awaiting requested review from mwear mwear is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@scar-lovevery @fbogsany @ahayworth @robertlaurin