Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow samplers to modify tracestate #231

Closed
jtescher opened this issue Sep 25, 2020 · 1 comment · Fixed by #237
Closed

Allow samplers to modify tracestate #231

jtescher opened this issue Sep 25, 2020 · 1 comment · Fixed by #237
Assignees
@TommyCpp

Comments

@jtescher
Copy link
Member

See the spec change for details.
@TommyCpp
Copy link
Contributor

TommyCpp commented Oct 1, 2020

If I understand it correctly. Just need to add a tracestate in SamplingResult. Should be a easy fix. I could work on this if no one else has already grab it.

@TommyCpp TommyCpp mentioned this issue Oct 2, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TommyCpp TommyCpp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[trace] Allow ShouldSample implementation to modify trace state. TommyCpp/opentelemetry-rust
2 participants
@jtescher @TommyCpp