Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[trace] Allow ShouldSample implementation to modify trace state. #237

Merged
merged 1 commit into from
Oct 2, 2020
Merged

[trace] Allow ShouldSample implementation to modify trace state. #237

merged 1 commit into from
Oct 2, 2020

Conversation

TommyCpp
Copy link
Contributor

@TommyCpp TommyCpp commented Oct 2, 2020 •
edited
Loading

Add trace_state into SamplingResult.
See open-telemetry/opentelemetry-specification#988 for details.

fix #231

@TommyCpp TommyCpp marked this pull request as ready for review October 2, 2020 02:16
@TommyCpp TommyCpp requested a review from a team October 2, 2020 02:16
jtescher
jtescher approved these changes Oct 2, 2020
View reviewed changes
Copy link
Member

@jtescher jtescher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @TommyCpp

@jtescher jtescher merged commit 0841b9a into open-telemetry:master Oct 2, 2020
@TommyCpp TommyCpp deleted the issue231 branch November 23, 2020 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtescher jtescher jtescher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow samplers to modify tracestate
2 participants
@TommyCpp @jtescher