-
Notifications
You must be signed in to change notification settings - Fork 449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update trace config max defaults #268
Comments
Do I understand correctly that the task is reduced to replacing these constants with the values of environment variables (with a default value of 1000 of course)? |
@morigs the conventions so far in this workspace have been to have constants (that need to be updated here) and the struct or builder to have a |
Ok. So |
@morigs I personally prefer that env vars should always be used when available as well. This project went with the explicit version both because of conventions set by the golang impl (e.g. E.g. It does have the somewhat substantial downside that consumers of the API may be confused when they set env vars that do not have the effect they expect. I would be open to re-evaluating the decision to use explicit from env if you want to open an issue for that (e.g. we could make all fields private across the projects to force going through constructors that would pick up the environment) |
Totally agreed
I believe it's better to go this way. But I'm new to the OTel ecosystem and don't know all conventions and best practices. So I rely on your decision |
I'd be happy to move to private fields and automated environment lookup as well. This would also enable us to add new configuration options without making that a breaking change, I think. |
See the spec change here for details open-telemetry/opentelemetry-specification#942
The text was updated successfully, but these errors were encountered: