Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove from_env and use env vars by default #459

Merged
merged 1 commit into from
Feb 22, 2021
Merged

Conversation

jtescher
Copy link
Member

Currently environment variables are not picked up by default and must be opted in via explicit calls to from_env in builders. This change updates this behavior by removing the from_env methods and instead checking the respective variables in constructors.

Resolves #434
Resolves #268
Resolves #168

Currently environment variables are not picked up by default and must be
opted in via explicit calls to `from_env` in builders. This change
updates this behavior by removing the `from_env` methods and instead
checking the respective variables in constructors.
@jtescher jtescher requested a review from a team February 21, 2021 22:59
@codecov
Copy link

codecov bot commented Feb 21, 2021

Codecov Report

Merging #459 (892a98a) into main (f79586b) will increase coverage by 0.69%.
The diff coverage is 75.40%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #459      +/-   ##
==========================================
+ Coverage   47.88%   48.57%   +0.69%     
==========================================
  Files          95       95              
  Lines        8736     8747      +11     
==========================================
+ Hits         4183     4249      +66     
+ Misses       4553     4498      -55     
Impacted Files Coverage Δ
opentelemetry-jaeger/src/lib.rs 89.36% <ø> (ø)
opentelemetry/src/sdk/trace/id_generator/aws.rs 76.92% <ø> (ø)
opentelemetry/src/sdk/trace/provider.rs 58.18% <0.00%> (ø)
opentelemetry/src/sdk/trace/config.rs 36.95% <40.00%> (+7.22%) ⬆️
opentelemetry/src/sdk/trace/span_processor.rs 78.16% <80.00%> (-2.11%) ⬇️
opentelemetry/src/sdk/resource.rs 79.31% <92.30%> (+1.74%) ⬆️
opentelemetry-jaeger/src/exporter/mod.rs 40.89% <100.00%> (+0.57%) ⬆️
...ntelemetry/src/sdk/metrics/aggregators/ddsketch.rs 76.95% <0.00%> (+0.19%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f79586b...892a98a. Read the comment docs.

Copy link
Contributor

@TommyCpp TommyCpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jtescher jtescher merged commit 42c37f1 into main Feb 22, 2021
@jtescher jtescher deleted the use-env-vars-by-default branch February 22, 2021 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants