Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SpanRef::set_attributes mutability #1038

Merged
merged 1 commit into from
Apr 24, 2023

Conversation

jtescher
Copy link
Member

SpanRefs already synchronize access so the reference can be &self instead of &mut self.

@jtescher jtescher requested a review from a team as a code owner April 23, 2023 21:50
@codecov
Copy link

codecov bot commented Apr 23, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (f42c11d) 55.1% compared to head (fc4f71f) 55.1%.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1038   +/-   ##
=====================================
  Coverage   55.1%   55.1%           
=====================================
  Files        149     149           
  Lines      18143   18143           
=====================================
  Hits       10006   10006           
  Misses      8137    8137           
Impacted Files Coverage Δ
opentelemetry-api/src/trace/context.rs 21.3% <0.0%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jtescher jtescher merged commit a9399e9 into open-telemetry:main Apr 24, 2023
@jtescher jtescher deleted the fix-attributes-mutability branch April 24, 2023 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants