-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move OrderMap module to root of otel-api crate #1061
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #1061 +/- ##
=====================================
Coverage 54.9% 54.9%
=====================================
Files 151 151
Lines 18242 18242
=====================================
Hits 10025 10025
Misses 8217 8217
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks. Could you add a CHANGELOG?
this may be breaking change for existing trace users as they have to change the specified path of this module in their code
One way to mitigate it is to re-export it in traces module
Thanks, added changelog, and re-export in trace module. |
Fixes #
Design discussion issue (if applicable) #
Changes
OrderMap module is currently stored under
crate::opentelemetry-api::trace
hierarchy. Going ahead as part of #788, this data structure would also be used in logs bridge-api/sdk to log attributes. As this is a generic data structure, and doesn't logically belong to Trace, moving it to root of opentelemetry-api crate. This will enable it to used in both trace and logs in much cleaner way.Merge requirement checklist
CHANGELOG.md
files updated for non-trivial, user-facing changes