Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start adding metrics advanced (view) examples #1170

Merged

Conversation

cijothomas
Copy link
Member

Part of #1060

Changes

Add a metrics-advanced example, with 2 scenarios (rename, drop attributes) explained. If this direction is okay, I can add further scenarios. A lot of folks get confused by View, so hopefully these are useful examples.

Next steps would be to show how to change Histogram bounds (a common ask), drop an Instrument alltogether, changing temporality (default is cumulative, but a lot of backends need delta only) etc.

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@cijothomas cijothomas requested a review from a team July 28, 2023 19:54
@codecov
Copy link

codecov bot commented Jul 28, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (fb14199) 49.6% compared to head (f83710c) 49.6%.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1170   +/-   ##
=====================================
  Coverage   49.6%   49.6%           
=====================================
  Files        165     165           
  Lines      20522   20522           
=====================================
  Hits       10198   10198           
  Misses     10324   10324           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jtescher jtescher merged commit 6962621 into open-telemetry:main Jul 29, 2023
@cijothomas cijothomas deleted the cijothomas/metric-example-advanced branch July 29, 2023 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants