Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump MSRV to 1.64 and indexmap to 2.0 #1203

Merged
merged 2 commits into from
Aug 11, 2023
Merged

bump MSRV to 1.64 and indexmap to 2.0 #1203

merged 2 commits into from
Aug 11, 2023

Conversation

shaun-cox
Copy link
Contributor

@shaun-cox shaun-cox commented Aug 11, 2023

Due to requirement of #1199, this is a separate PR to bump MSRV.
Contributing factors:

  • tokio now has MSRV of 1.63
  • we're using older indexmap 1.18, and indexmap 2.0 has MSRV of 1.64

Changes

  • bump MSRV to 1.64
  • bump indexmap to 2.0
  • fix newly exposed lint about deriving Default instead of manually implementing

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@codecov
Copy link

codecov bot commented Aug 11, 2023

Codecov Report

Patch coverage: 24.4% and no project coverage change.

Comparison is base (7607ad3) 49.6% compared to head (b8b816c) 49.7%.
Report is 6 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1203   +/-   ##
=====================================
  Coverage   49.6%   49.7%           
=====================================
  Files        164     172    +8     
  Lines      20653   20710   +57     
=====================================
+ Hits       10258   10301   +43     
- Misses     10395   10409   +14     
Files Changed Coverage Δ
opentelemetry-api/src/lib.rs 100.0% <ø> (ø)
opentelemetry-api/src/order_map.rs 4.2% <0.0%> (ø)
...emetry-jaeger/src/exporter/config/collector/mod.rs 51.6% <ø> (ø)
opentelemetry-jaeger/src/lib.rs 95.3% <ø> (ø)
opentelemetry-otlp/src/exporter/grpcio/logs.rs 0.0% <0.0%> (ø)
opentelemetry-otlp/src/exporter/grpcio/mod.rs 35.4% <0.0%> (ø)
opentelemetry-otlp/src/exporter/grpcio/trace.rs 0.0% <0.0%> (ø)
opentelemetry-otlp/src/exporter/http/logs.rs 0.0% <0.0%> (ø)
opentelemetry-otlp/src/exporter/http/metrics.rs 0.0% <0.0%> (ø)
opentelemetry-otlp/src/exporter/http/mod.rs 0.0% <0.0%> (ø)
... and 16 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@TommyCpp TommyCpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe need to add CHANGELOG but otherwise LGTM Thanks!

README.md Show resolved Hide resolved
@shaun-cox
Copy link
Contributor Author

Will be updating CHANGELOG.md's, then readying this for review/approval...

@shaun-cox shaun-cox marked this pull request as ready for review August 11, 2023 19:16
@shaun-cox shaun-cox requested a review from a team August 11, 2023 19:16
@djc djc merged commit 4fd68e3 into open-telemetry:main Aug 11, 2023
@djc
Copy link
Contributor

djc commented Aug 11, 2023

Thanks for taking care of this.

@shaun-cox shaun-cox deleted the msrv branch August 11, 2023 21:59
@hdost hdost added version:breaking Tag PR which will make breaking changes. Same as bumping the "major" in semver. https://semver.org/ version:minor Tag PR which would make sense to bump the "minor" in semver. https://semver.org/ and removed version:breaking Tag PR which will make breaking changes. Same as bumping the "major" in semver. https://semver.org/ labels Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
version:minor Tag PR which would make sense to bump the "minor" in semver. https://semver.org/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants