-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump MSRV to 1.64 and indexmap to 2.0 #1203
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1203 +/- ##
=====================================
Coverage 49.6% 49.7%
=====================================
Files 164 172 +8
Lines 20653 20710 +57
=====================================
+ Hits 10258 10301 +43
- Misses 10395 10409 +14
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe need to add CHANGELOG but otherwise LGTM Thanks!
Will be updating CHANGELOG.md's, then readying this for review/approval... |
Thanks for taking care of this. |
Due to requirement of #1199, this is a separate PR to bump MSRV.
Contributing factors:
tokio
now has MSRV of 1.63indexmap 1.18
, andindexmap 2.0
has MSRV of 1.64Changes
indexmap
to 2.0Default
instead of manually implementingMerge requirement checklist
CHANGELOG.md
files updated for non-trivial, user-facing changes