-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove old global meter provider shutdown method #1412
Remove old global meter provider shutdown method #1412
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1412 +/- ##
=====================================
Coverage 57.3% 57.3%
=====================================
Files 146 146
Lines 18179 18184 +5
=====================================
+ Hits 10422 10434 +12
+ Misses 7757 7750 -7 ☔ View full report in Codecov by Sentry. |
ℹ️ I opened a discussion here to find a valid replacement for when the MeterProvider is not easily accessible, since the removal of |
@Oliboy50 This issue is specific to the MetricsLayer provided by tracing-opentelemetry. And not while using the Otel Metrics API from this repo. Would you like to open a discussion within that repo. As I replied in our discussion:
|
@lalitb Following your advices, I opened a discussion there |
Changes
This change removes the old
global::shutdown_meter_provider
method which is not part of the metrics API spec, and properly documents theSdkMeterProvider::shutdown
method which is spec compliant.Merge requirement checklist
CHANGELOG.md
files updated for non-trivial, user-facing changes