Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: send propagator error to global error handler #1640

Merged

Conversation

TommyCpp
Copy link
Contributor

@TommyCpp TommyCpp commented Mar 25, 2024

One issue with our propagator setup is when there is an error we usually just return default context and throw the error away.

Changes

  • Add a new error type for propagator
  • Export errors from extracting and injecting to global error handler rather then ignore them
  • No change made to the result of extract and injec

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

Copy link

codecov bot commented Mar 25, 2024

Codecov Report

Attention: Patch coverage is 77.63158% with 17 lines in your changes are missing coverage. Please review.

Project coverage is 68.9%. Comparing base (815e387) to head (ecd96e5).
Report is 1 commits behind head on main.

Files Patch % Lines
opentelemetry-sdk/src/propagation/baggage.rs 68.7% 10 Missing ⚠️
opentelemetry/src/propagation/mod.rs 53.3% 7 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main   #1640     +/-   ##
=======================================
- Coverage   68.9%   68.9%   -0.1%     
=======================================
  Files        136     136             
  Lines      19385   19429     +44     
=======================================
+ Hits       13368   13396     +28     
- Misses      6017    6033     +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TommyCpp TommyCpp marked this pull request as ready for review March 25, 2024 15:31
@TommyCpp TommyCpp requested a review from a team as a code owner March 25, 2024 15:31
@TommyCpp TommyCpp marked this pull request as draft March 25, 2024 15:32
@TommyCpp
Copy link
Contributor Author

TommyCpp commented Mar 25, 2024

Need to add change log

@TommyCpp TommyCpp force-pushed the zhongyang/add-propagation-errors branch from 57cd692 to ecd96e5 Compare March 26, 2024 06:00
@TommyCpp TommyCpp marked this pull request as ready for review March 26, 2024 06:00
Copy link
Member

@cijothomas cijothomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Will you be adding similar to the trace_context propagator as well?

@cijothomas cijothomas merged commit 8483914 into open-telemetry:main Mar 28, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants