-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Logs API] Remove global provider for Logs #1691
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for reducing public API surface!
This should significantly help us achieve the release goals!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. One nit, feel free to ignore if you don't agree.
Co-authored-by: Zhongyang Wu <zhongyang.wu@outlook.com>
Changes
As discussed here - LoggerProviders are not meant for end users to get loggers from. It is only required for the log bridges.
So removing all the global constructs for the logs i.e -
opentelemetry::global::logger
opentelemetry::global::set_logger_provider
opentelemetry:global::shutdown_logger_provider
opentelemetry::global::logger_provider
opentelemetry::global::GlobalLoggerProvider
opentelemetry::global::ObjectSafeLoggerProvider
Merge requirement checklist
CHANGELOG.md
files updated for non-trivial, user-facing changes