Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use token for code cov #1772

Merged
merged 2 commits into from
May 15, 2024

Conversation

cijothomas
Copy link
Member

Fixes #
Design discussion issue (if applicable) #

Changes

Please provide a brief description of the changes here.

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@cijothomas cijothomas requested a review from a team May 15, 2024 16:43
@lalitb
Copy link
Member

lalitb commented May 15, 2024

I think there is a edge condition, there is an issue for that - codecov/feedback#358.

Copy link

codecov bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.6%. Comparing base (348ec9e) to head (80243d7).
Report is 40 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #1772     +/-   ##
=======================================
+ Coverage   71.0%   71.6%   +0.6%     
=======================================
  Files        135     136      +1     
  Lines      20751   20857    +106     
=======================================
+ Hits       14746   14951    +205     
+ Misses      6005    5906     -99     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cijothomas cijothomas merged commit 4042f51 into open-telemetry:main May 15, 2024
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants