Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sdk: expose Tracer::id_generator() #1934

Merged
merged 1 commit into from
Jul 15, 2024
Merged

Conversation

djc
Copy link
Contributor

@djc djc commented Jul 15, 2024

Changes

#1755 privatized Tracer::provider() which tracing-opentelemetry needs to build its PreSampledTracer. Pending a long-term solution for #1571, add a more restricted #[doc(hidden)] Tracer::id_generator() method that only exposes the internal provider's config().id_generator.

This is blocking the 0.24 release.

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@djc djc requested a review from a team July 15, 2024 07:57
@djc djc mentioned this pull request Jul 15, 2024
4 tasks
@djc djc force-pushed the tracer-id-gen branch from 9c25a82 to 428fa81 Compare July 15, 2024 07:58
Copy link

codecov bot commented Jul 15, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 74.9%. Comparing base (cdf5f03) to head (428fa81).

Files Patch % Lines
opentelemetry-sdk/src/trace/tracer.rs 0.0% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main   #1934     +/-   ##
=======================================
- Coverage   74.9%   74.9%   -0.1%     
=======================================
  Files        122     122             
  Lines      20308   20311      +3     
=======================================
  Hits       15217   15217             
- Misses      5091    5094      +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cijothomas
Copy link
Member

Merging quickly to unblock release progress.

@cijothomas cijothomas merged commit 5922205 into open-telemetry:main Jul 15, 2024
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants