Prevent lint warnings if internal-logs features is not enabled. #2196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lalitb
commented
Oct 11, 2024
| #[cfg(not(feature = "internal-logs"))] | ||
| const _: () = { | ||
| let _ = $name; | ||
| }; |
There was a problem hiding this comment.
const here will (double) ensure that the rust compiler will optimize out this at compile-time, and so no runtime code generated.
|
moving to draft to fix some CI. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2196 +/- ##
=====================================
Coverage 79.1% 79.2%
=====================================
Files 121 121
Lines 20879 20870 -9
=====================================
- Hits 16534 16532 -2
+ Misses 4345 4338 -7 ☔ View full report in Codecov by Sentry. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Design discussion issue (if applicable) #
Changes
Please provide a brief description of the changes here.
Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial, user-facing changes