Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[propagator] Ensure compliance with b3 propagator spec. #319

Merged
merged 3 commits into from
Oct 30, 2020
Merged

[propagator] Ensure compliance with b3 propagator spec. #319

merged 3 commits into from
Oct 30, 2020

Conversation

TommyCpp
Copy link
Contributor

  1. Force extract to try to extract from single header format first, if it doesn't work, then try multiple header format.
  2. Don't attch empty span context as remote span context.

Fix #314

@TommyCpp
[propagator] Ensure compliance with b3 propagator spec.
3a93c70 
Force extract to try to extract from single header format first, if it doesn't work, then try multiple header format.
@TommyCpp TommyCpp requested a review from a team October 30, 2020 00:34
jtescher
jtescher reviewed Oct 30, 2020
View reviewed changes
src/sdk/propagation/b3.rs Outdated Show resolved Hide resolved
jtescher
jtescher approved these changes Oct 30, 2020
View reviewed changes
Copy link
Member

@jtescher jtescher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@jtescher jtescher merged commit 468adf9 into open-telemetry:master Oct 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtescher jtescher jtescher approved these changes

@frigus02 frigus02 frigus02 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ensure compliance with b3 propagator spec
3 participants
@TommyCpp @jtescher @frigus02