Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set status tag in Zipkin & Jaeger #383

Merged
merged 2 commits into from
Dec 14, 2020
Merged

Set status tag in Zipkin & Jaeger #383

merged 2 commits into from
Dec 14, 2020

Conversation

TommyCpp
Copy link
Contributor

closes #380

@codecov
Copy link

codecov bot commented Dec 13, 2020 •
edited
Loading

Codecov Report

Merging #383 (749f4ff) into master (f780d91) will increase coverage by 0.09%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #383      +/-   ##
==========================================
+ Coverage   49.34%   49.43%   +0.09%     
==========================================
  Files          66       66              
  Lines        5326     5352      +26     
==========================================
+ Hits         2628     2646      +18     
- Misses       2698     2706       +8
Impacted Files Coverage Δ
opentelemetry/src/api/trace/span.rs 54.05% <0.00%> (-10.47%) ⬇️
opentelemetry/src/sdk/trace/span.rs 82.00% <93.10%> (+0.92%) ⬆️
...ntelemetry/src/sdk/metrics/aggregators/ddsketch.rs 76.76% <0.00%> (-0.20%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f780d91...749f4ff. Read the comment docs.

@TommyCpp TommyCpp marked this pull request as ready for review December 13, 2020 20:36
@TommyCpp TommyCpp requested a review from a team December 13, 2020 20:36
jtescher
jtescher approved these changes Dec 14, 2020
View reviewed changes
Copy link
Member

@jtescher jtescher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@jtescher jtescher merged commit 232a87e into open-telemetry:master Dec 14, 2020
@TommyCpp TommyCpp deleted the tommycpp/status branch December 16, 2020 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtescher jtescher jtescher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set status tag in Zipkin & Jaeger
2 participants
@TommyCpp @jtescher