Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update grpcio version and add the coverage badge #556

Merged
merged 3 commits into from
May 21, 2021

Conversation

TommyCpp
Copy link
Contributor

fix #554
fix #553

We probably need to work on adding some tests around the jaeger exporter. I think the metrics' tests can be delayed after tracing GA.

@TommyCpp TommyCpp requested a review from a team May 21, 2021 00:47
README.md Outdated Show resolved Hide resolved
Co-authored-by: Julian Tescher <julian@tescher.me>
Copy link
Member

@jtescher jtescher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented May 21, 2021

Codecov Report

Merging #556 (eb91076) into main (ebb950a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##            main    #556   +/-   ##
=====================================
  Coverage   54.5%   54.5%           
=====================================
  Files         97      97           
  Lines       8534    8534           
=====================================
  Hits        4659    4659           
  Misses      3875    3875           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebb950a...eb91076. Read the comment docs.

@jtescher jtescher merged commit 1235682 into open-telemetry:main May 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants