pub use opentelemetry_api::trace::WithContext
#893
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #823
This scenario is specifically meant to make instrumenting async functions with contexts:
Right now, calling
some_async_fn().instrument(tracing_span)
does not set the span's context as thesome_async_fn
's currentContext
.Instead, the current flow is to chain both methods:
some_async_fn().with_context(span.context()).instrument(span).await
This is a first step to bundling ot Contexts more consistently.
Traits involved:
tracing::instrument::Instrument
opentelemetry::trace::FutureExt