Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Display on Baggage #921

Merged
merged 4 commits into from
Dec 12, 2022

Conversation

wperron
Copy link
Contributor

@wperron wperron commented Nov 25, 2022

Tests are taken from the Go test cases

Fixes #905

@wperron wperron requested a review from a team as a code owner November 25, 2022 14:51
@wperron wperron requested a review from djc November 28, 2022 14:27
@codecov
Copy link

codecov bot commented Nov 28, 2022

Codecov Report

Base: 67.1% // Head: 67.2% // Increases project coverage by +0.0% 🎉

Coverage data is based on head (47f9da5) compared to base (44b9020).
Patch coverage: 100.0% of modified lines in pull request are covered.

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #921   +/-   ##
=====================================
  Coverage   67.1%   67.2%           
=====================================
  Files        115     115           
  Lines       8959    8998   +39     
=====================================
+ Hits        6016    6048   +32     
- Misses      2943    2950    +7     
Impacted Files Coverage Δ
opentelemetry-api/src/baggage.rs 87.5% <100.0%> (+2.9%) ⬆️
opentelemetry-http/src/lib.rs 3.5% <0.0%> (-5.3%) ⬇️
opentelemetry-sdk/src/trace/span_processor.rs 83.0% <0.0%> (-0.3%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

opentelemetry-api/src/baggage.rs Outdated Show resolved Hide resolved
@wperron
Copy link
Contributor Author

wperron commented Nov 29, 2022

Is that failing test a known flaky test? it's passing locally and I'm not sure why it'd be failing here 🤔

@CleanCut
Copy link

CleanCut commented Dec 1, 2022

@wperron Hmm, cargo test passes for me as well. But if I run script/test.sh then it fails just as in CI, and it changes three files (which need to be committed and added to the PR according to the output).

@wperron
Copy link
Contributor Author

wperron commented Dec 1, 2022

Ah makes sense, I'll get that updated sometime today 👍

@TommyCpp
Copy link
Contributor

@jtescher Looks like we need your approval to merge. Any more comments or it's good to merge?

@TommyCpp TommyCpp merged commit bf5ca2f into open-telemetry:main Dec 12, 2022
@wperron wperron deleted the 905-baggage-string branch December 12, 2022 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Encode Baggage as string
5 participants