-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update some dependencies #969
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #969 +/- ##
=======================================
+ Coverage 69.7% 69.9% +0.2%
=======================================
Files 116 116
Lines 9038 8920 -118
=======================================
- Hits 6307 6243 -64
+ Misses 2731 2677 -54
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Perhaps the comments about pruning, could be an issue raised. I would agree that the surface area of the project should be reduced, and I believe I had made similar comments in the past when I mentioned making some of the code build separately. By example moving code into a separate contrib repo (might have been a different suggestion, but the core argument is the same) keep the core well maintained and allow for contribution on but keep support low on non-core components. |
I took a stab djc#1 to update some dependencies in some of the creates built on top of the work of this PR. I second the idea to move the example to their crates and having a contrib repo(#841) to store less core creates. I can open an issue with admins to create a new repo and assign proper access to maintainer/approvers Looking at the issue on grpcio. It seems they are still open to adding support for proto 3? I am open to removing grpcio support but I don't think we need to figure it out now. I feel like we can open an issue to gather some ideas on if anyone is hard depending on grpcio |
djc#2 |
Tonic 0.8 requires MSRV > 1.60
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks
Thank you for looking into the MSRV stuff and the other crates! |
Here are some of the easy updates from #922. I left out:
examples
For the examples, I think we have way too many example projects to reasonably maintain over time, so I think we should prune back on how many things we want to explicitly support. It would probably help if we move examples related to a particular integration crate into that crate, so that PRs are forced to update related examples. (In many cases, it looks like the example projects mainly duplicate example code from the doctests or tests in the integration crates...) This also conveniently allows me to avoid dealing with unrelated changes suggested in review.
As for grpc and protobuf, it looks like the grpcio maintainers are uninterested in updating grpcio to use protobuf 3. Personally, I think the prost/tonic stack is more attractive in any way, so I question the need for this project to maintain two gRPC integrations in parallel (and am personally not willing to spend time on that).
The base64 crate unfortunately made their API worse in recent releases, and the maintainer is unwilling to improve on that.