Session handling #229
Open
Session handling #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpmunz
reviewed
Jun 25, 2024
| if (sessionId === null) { | ||
| const generateSessionId = getIdGenerator(16); | ||
| sessionId = generateSessionId(); | ||
| sessionStorage.setItem(SESSION_STORAGE_KEY, sessionId); |
There was a problem hiding this comment.
it may be worth also storing the created/last accessed time and allowing the manager optionally to be configured with how much time can pass before considering the old session to be expired, here's some of that being done on Android for reference: https://github.com/open-telemetry/opentelemetry-android/blob/main/android-agent/src/main/java/io/opentelemetry/android/SessionId.java
bidetofevil
reviewed
Aug 6, 2024
| * returns true. | ||
| * @param span the Span that just ended. | ||
| */ | ||
| onEnd(_: ReadableSpan): void { |
There was a problem hiding this comment.
Do we want to clear the session once it ends?
There was a problem hiding this comment.
This function is called for each span when it ends. As far as clearing the session.id attribute, it is retrieved from the manager for every span (not cached).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes a draft of managing session ID.
web-common, so that the components can be used outside of the Web SDKsession.idattribute