Skip to content

Commit

Permalink
nits
Browse files Browse the repository at this point in the history
  • Loading branch information
lmolkova committed Jun 1, 2022
1 parent 42ad71f commit 23f8f02
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions semantic_conventions/trace/messaging.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ groups:
- id: temp_destination
type: boolean
requirement_level:
conditionally_required: If value is `true`. When missing, the value assumed to be false.
conditionally_required: If value is `true`. When missing, the value is assumed to be `false`.
brief: 'A boolean that is true if the message destination is temporary.'
- id: protocol
type: string
Expand Down Expand Up @@ -178,7 +178,7 @@ groups:
- id: tombstone
type: boolean
requirement_level:
conditionally_required: If value is `true`. When missing, the value assumed to be false.
conditionally_required: If value is `true`. When missing, the value is assumed to be `false`.
brief: 'A boolean that is true if the message is a tombstone.'

- id: messaging.rocketmq
Expand Down
4 changes: 2 additions & 2 deletions specification/trace/semantic_conventions/messaging.md
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ The following operations related to messages are defined for these semantic conv

**[1]:** If the message destination is either a `queue` or `topic`.

**[2]:** If value is `true`. When missing, the value assumed to be false.
**[2]:** If value is `true`. When missing, the value is assumed to be `false`.

**[3]:** This should be the IP/hostname of the broker (or other network-level peer) this specific message is sent to/received from.

Expand Down Expand Up @@ -215,7 +215,7 @@ For Apache Kafka, the following additional attributes are defined:

**[1]:** If the key type is not string, it's string representation has to be supplied for the attribute. If the key has no unambiguous, canonical string form, don't include its value.

**[2]:** If value is `true`. When missing, the value assumed to be false.
**[2]:** If value is `true`. When missing, the value is assumed to be `false``.
<!-- endsemconv -->

For Apache Kafka producers, [`peer.service`](./span-general.md#general-remote-service-attributes) SHOULD be set to the name of the broker or service the message will be sent to.
Expand Down

0 comments on commit 23f8f02

Please sign in to comment.