Skip to content

Commit

Permalink
Fix based on comments
Browse files Browse the repository at this point in the history
  • Loading branch information
tigrannajaryan committed Dec 10, 2021
1 parent 3c06f1f commit 2fe7827
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 9 deletions.
5 changes: 2 additions & 3 deletions specification/common/attribute-naming.md
Original file line number Diff line number Diff line change
Expand Up @@ -70,9 +70,8 @@ Names SHOULD follow these rules:

## Name Reuse Prohibition

It is prohibited to introduce a new attribute with a name that matches a name of
an attribute that existed in the past but was renamed (with a corresponding
schema file).
A new attribute MUST NOT be added with the same name as an attribute that
existed in the past but was renamed (with a corresponding schema file).

When introducing a new attribute name check all existing schema files to make
sure the name does not appear as a key of any "rename_attributes" section (keys
Expand Down
5 changes: 2 additions & 3 deletions specification/metrics/semantic_conventions/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -69,9 +69,8 @@ ambiguous.

### Name Reuse Prohibition

It is prohibited to introduce a new metric with a name that matches a name of
a metric that existed in the past but was renamed (with a corresponding
schema file).
A new metric MUST NOT be added with the same name as a metric that existed in
the past but was renamed (with a corresponding schema file).

When introducing a new metric name check all existing schema files to make sure
the name does not appear as a key of any "rename_metrics" section (keys denote
Expand Down
5 changes: 2 additions & 3 deletions specification/trace/semantic_conventions/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,8 @@ OpenTelemetry also defines the concept of overarching [Resources](../../resource

## Event Name Reuse Prohibition

It is prohibited to introduce a new event with a name that matches a name of an
event that existed in the past but was renamed (with a corresponding schema
file).
A new event MUST NOT be added with the same name as an event that existed in
the past but was renamed (with a corresponding schema file).

When introducing a new event name check all existing schema files to make sure
the name does not appear as a key of any "rename_events" section (keys denote
Expand Down

0 comments on commit 2fe7827

Please sign in to comment.