Skip to content

Commit

Permalink
Add cloud spanner and mssql compact to db specifications (#3105)
Browse files Browse the repository at this point in the history
  • Loading branch information
mrblonde91 committed Jan 23, 2023
1 parent 948fdf3 commit 8b1a057
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 0 deletions.
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,9 @@ release.

## v1.17.0 (2023-01-17)

- Add Cloud Spanner and Microsoft SQL Server Compact to db.system semantic conventions.
[#3105](https://github.com/open-telemetry/opentelemetry-specification/pull/3105)

### Context

- No changes.
Expand Down
6 changes: 6 additions & 0 deletions semantic_conventions/trace/database.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,9 @@ groups:
- id: mssql
value: 'mssql'
brief: 'Microsoft SQL Server'
- id: mssqlcompact
value: 'mssqlcompact'
brief: 'Microsoft SQL Server Compact'
- id: mysql
value: 'mysql'
brief: 'MySQL'
Expand Down Expand Up @@ -160,6 +163,9 @@ groups:
- id: clickhouse
value: 'clickhouse'
brief: 'ClickHouse'
- id: spanner
value: 'spanner'
brief: 'Cloud Spanner'
- id: connection_string
tag: connection-level
type: string
Expand Down
2 changes: 2 additions & 0 deletions specification/trace/semantic_conventions/database.md
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@ Some database systems may allow a connection to switch to a different `db.user`,
|---|---|
| `other_sql` | Some other SQL database. Fallback only. See notes. |
| `mssql` | Microsoft SQL Server |
| `mssqlcompact` | Microsoft SQL Server Compact |
| `mysql` | MySQL |
| `oracle` | Oracle Database |
| `db2` | IBM Db2 |
Expand Down Expand Up @@ -117,6 +118,7 @@ Some database systems may allow a connection to switch to a different `db.user`,
| `cockroachdb` | CockroachDB |
| `opensearch` | OpenSearch |
| `clickhouse` | ClickHouse |
| `spanner` | Cloud Spanner |
<!-- endsemconv -->

### Notes and well-known identifiers for `db.system`
Expand Down

0 comments on commit 8b1a057

Please sign in to comment.