Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement three more types of Metric #146

Closed
SergeyKanzhelev opened this issue Jun 20, 2019 · 5 comments
Closed

Implement three more types of Metric #146

SergeyKanzhelev opened this issue Jun 20, 2019 · 5 comments
Assignees
@jmacd
Labels
area:sdk Related to the SDK spec:metrics Related to the specification/metrics directory
Milestone
Alpha v0.2

Comments

@SergeyKanzhelev
Copy link
Member

Proposed API only exposed two metric types: counter and gauge. Other types needs to be represented - histogram and summary

https://github.com/open-telemetry/opentelemetry-proto/blob/fe0fa0bd3ef0a42f3ccc6645f7b11e26418f96b1/src/opentelemetry/proto/metrics/v1/metrics.proto#L62-L97
@SergeyKanzhelev SergeyKanzhelev added this to the API revision: 07-2019 milestone Jun 20, 2019
@SergeyKanzhelev SergeyKanzhelev added the area:api Cross language API specification issue label Jun 20, 2019
@jmacd
Copy link
Contributor

jmacd commented Jun 26, 2019

@iredelmeier and I are preparing several metrics RFCs and I would suggest we hold off on specifying Histogram and Summary until then.

@bogdandrutu
Copy link
Member

Please make sure that this is backwards compatible with the OpenCensus which has all these types supported (directly or indirectly).

@jmacd
Copy link
Contributor

jmacd commented Jul 1, 2019

See issue 169.

@bogdandrutu bogdandrutu mentioned this issue Jul 2, 2019
Merged
@tedsuo tedsuo mentioned this issue Jul 11, 2019
Closed
@iredelmeier iredelmeier added the spec:metrics Related to the specification/metrics directory label Jul 30, 2019
@SergeyKanzhelev SergeyKanzhelev modified the milestones: API revision: 07-2019, Alpha v0.2 Sep 27, 2019
@SergeyKanzhelev
Copy link
Member Author

@jmacd it seems like your metrics proposal addresses this issue

@bogdandrutu bogdandrutu added area:sdk Related to the SDK and removed area:api Cross language API specification issue labels Oct 10, 2019
@bogdandrutu
Copy link
Member

bogdandrutu commented Oct 10, 2019 •
edited
Loading

The protos that you refer to @SergeyKanzhelev are our exported data. For the API we record only 3 metrics see the #250 PR.

This can be closed for the moment and we can address the supported aggregations in the metrics SDK. Feel free to reopen if you think we need to track that.

rockb1017 pushed a commit to rockb1017/opentelemetry-specification that referenced this issue Nov 18, 2021
@MrAlias
Clarify RUM beaconEndpoint value enforcement (open-telemetry#146)
19cd66b 
Some systems, Android, cannot enforce this configuration value at the
library level. It needs to be enforced at the application level.
Therefore, this part of the specification is unimplementable by the
Android RUM library. This adds an exception to this requirement to allow
the Android RUM library to be compliant.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmacd jmacd

Labels
area:sdk Related to the SDK spec:metrics Related to the specification/metrics directory
Projects
None yet
Milestone
Alpha v0.2
Development

No branches or pull requests
4 participants
@bogdandrutu @iredelmeier @jmacd @SergeyKanzhelev