-
Notifications
You must be signed in to change notification settings - Fork 889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate metric semantic conventions into YAML #2001
Comments
How much YAML "code" sharing should there be between trace and metric conventions, regarding attributes? |
Discussed during the 10/07/2021 Metrics SIG meeting. @ocelotl is offering help here. Note that the current mechanism/script might need to be improved in order to support metrics, e.g. the support for instrument names. |
@Oberon00 This is a great question. For conventions that apply to both metrics and traces, IMO metric attributes could be a subset of the trace attributes. The reason being, all attributes would apply to both but metrics need to be lower cardinality. |
I'm more than happy to assist with this - @ocelotl did you need any help? |
Hey @jamesmoessis, I'll contact you via slack, thanks! |
@ocelotl Hey, I'll be more than happy to join this task as well! |
Maybe it's not known, so I'll post here: There's a PR in the build-tools repo that proposes a way to generate markdown tables from yaml for metrics. open-telemetry/build-tools#79 |
Hello folks, I've just done a bunch more work on open-telemetry/build-tools#79 and I believe it is now at a stage close to being merged. If anyone else wants to review the structure of the yaml and the generated markdown tables, please feel free to review and join the discussion on the PR 😄 |
I am not involved in this effort, please contact @jamesmoessis ✌️ |
This may need updates to the tool as we go to support how metric conventions are viewed, but we should work on getting metric semantic conventions into the YAML files for code generation.
Was raised in Java SiG for folks working on new types of instrumentation using metric semantic conventions.
The text was updated successfully, but these errors were encountered: