Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add http metrics yaml #3158

Merged
merged 6 commits into from
Feb 6, 2023
Merged

Add http metrics yaml #3158

merged 6 commits into from
Feb 6, 2023

Conversation

trask
Copy link
Member

@trask trask commented Jan 31, 2023

Fixes #2972 by adding text to say whether each instrument is required or optional (ideally should be added to yaml?)
Fixes #2822
Fixes #2974 by including same definition of net.host.name from tracing
Fixes #2976 by making http.server.request.size and friends optional

Changes

Adds http metrics yaml file based on @jamesmoessis build tool changes in open-telemetry/build-tools#79

For non-trivial changes, follow the change proposal process and link to the related issue(s) and/or OTEP(s), update the CHANGELOG.md, and also be sure to update spec-compliance-matrix.md if necessary.

Related issues #2666, #2001

NOTE: Markdown rendering will be improved in a future PR, after open-telemetry/build-tools#129

@arminru arminru added spec:metrics Related to the specification/metrics directory semconv:HTTP area:semantic-conventions Related to semantic conventions labels Jan 31, 2023
@trask trask marked this pull request as ready for review January 31, 2023 22:26
@trask trask requested review from a team January 31, 2023 22:26
Copy link
Member

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM considering the semantic convention is still Experimental. There are couple things which we might change (e.g. do we use ms as unit or s), not real blocker here.

@jsuereth
Copy link
Contributor

jsuereth commented Feb 2, 2023

+1 on adding the notion of optional instruments to the YAML. Is there a ticket open for this?

@trask
Copy link
Member Author

trask commented Feb 2, 2023

+1 on adding the notion of optional instruments to the YAML. Is there a ticket open for this?

open-telemetry/build-tools#132

@jsuereth jsuereth merged commit 1002125 into open-telemetry:main Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:semantic-conventions Related to semantic conventions semconv:HTTP spec:metrics Related to the specification/metrics directory
Projects
None yet
7 participants