Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure Metrics SDK View section #3532

Closed
pellared opened this issue Jun 2, 2023 · 7 comments · Fixed by #3559
Closed

Restructure Metrics SDK View section #3532

pellared opened this issue Jun 2, 2023 · 7 comments · Fixed by #3559
Labels
help wanted Extra attention is needed spec:metrics Related to the specification/metrics directory

Comments

@pellared
Copy link
Member

pellared commented Jun 2, 2023

I think that we can restructure a little to make the spec more consistent and readable.

Under MeterProvider section we could simply have something like:

### View Registration

The SDK MUST provide the functionality to register [`View`](#view) instances with a `MeterProvider`.

The rest could be moved to a dedicated ## View section similarly to other configuration components like exporters, readers.

Originally posted by @pellared in #3524 (comment)

@pellared
Copy link
Member Author

@carlosalberto Can you reopen this? I put a bad PR number in #3559 😬

@carlosalberto carlosalberto reopened this Jul 18, 2023
@tigrannajaryan
Copy link
Member

@pellared is there any further restructuring needed beyond #3524 ?

@tigrannajaryan tigrannajaryan added [label deprecated] triaged-needmoreinfo [label deprecated] The issue is triaged - the OTel community needs more information to decide spec:metrics Related to the specification/metrics directory labels Nov 1, 2023
@pellared
Copy link
Member Author

pellared commented Nov 2, 2023

@pellared is there any further restructuring needed beyond #3524 ?

I do not follow the question. The issue was created as part of #3524 review to make further improvements. See #3524 (comment)

@tigrannajaryan
Copy link
Member

@pellared is there any further restructuring needed beyond #3524 ?

I do not follow the question. The issue was created as part of #3524 review to make further improvements. See #3524 (comment)

OK. I misunderstood what this issue was about.

@tigrannajaryan tigrannajaryan added help wanted Extra attention is needed and removed [label deprecated] triaged-needmoreinfo [label deprecated] The issue is triaged - the OTel community needs more information to decide labels Nov 6, 2023
@svrnm svrnm added the triage:deciding:needs-info Not enough information. Left open to provide the author with time to add more details label May 6, 2024
@svrnm
Copy link
Member

svrnm commented May 6, 2024

@pellared is this still open?

@pellared
Copy link
Member Author

pellared commented May 16, 2024

It is still open, yet its priority and impact is low so it can be closed as nobody cared for almost 1 year. It is just an editorial refinement proposal.

@svrnm svrnm removed the triage:deciding:needs-info Not enough information. Left open to provide the author with time to add more details label May 16, 2024
@svrnm
Copy link
Member

svrnm commented May 16, 2024

thanks, @pellared, I removed the triage:* label for now, such that we can take another look in the next triage meeting

@dyladan dyladan closed this as completed May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed spec:metrics Related to the specification/metrics directory
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants