-
Notifications
You must be signed in to change notification settings - Fork 889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify metric SDK views section #3524
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MrAlias Feel free to resolve my comments.
Co-authored-by: Georg Pirklbauer <georg.pirklbauer@dynatrace.com> Co-authored-by: Robert Pająk <pellared@hotmail.com>
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see a the concerns about optionality to the user and optionality to the SDK and would be glad to see those improved in a future PR. I think this change is a big improvement either way.
(required)
or(optional)
. These terms have not normative value in the specification and are not clear about who their subject is (i.e. SDK author or SDK user).name
parameter of a stream configuration.