Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect claim in Prometheus compatibility doc #3944

Closed
tigrannajaryan opened this issue Mar 15, 2024 · 2 comments · Fixed by #3945
Closed

Incorrect claim in Prometheus compatibility doc #3944

tigrannajaryan opened this issue Mar 15, 2024 · 2 comments · Fixed by #3945
Assignees
@yurishkuro
Labels
spec:metrics Related to the specification/metrics directory

Comments

@tigrannajaryan
Copy link
Member

tigrannajaryan commented Mar 15, 2024 •
edited
Loading

The doc says:

In OTLP, the service.name, service.namespace, and service.instance.id triplet is required to be unique

This is incorrect, OTLP requires nothing like that. The uniqueness requirement is merely a semantic convention for Services, which are not even the only type of the Resource that Otel deals with.
@tigrannajaryan tigrannajaryan added the spec:metrics Related to the specification/metrics directory label Mar 15, 2024
@tigrannajaryan
Copy link
Member Author

@dashpole IIRC you worked on this doc, please take a look.

cc @jsuereth

@dashpole dashpole mentioned this issue Mar 15, 2024
Merged
@dashpole
Copy link
Contributor

Addressed with #3945

@tigrannajaryan tigrannajaryan mentioned this issue Mar 15, 2024
Merged
tigrannajaryan pushed a commit that referenced this issue Mar 20, 2024
@dashpole @jack-berg
prometheus compatibility: clarify that the service triplet is require…
032213c 
…d to be unique by semantic conventions (#3945)

Fixes
#3944

OTLP does not include that requirement.

Co-authored-by: jack-berg <34418638+jack-berg@users.noreply.github.com>
@reyang reyang mentioned this issue Apr 11, 2024
Merged
5 tasks
carlosalberto pushed a commit to carlosalberto/opentelemetry-specification that referenced this issue Oct 31, 2024
@dashpole @jack-berg
prometheus compatibility: clarify that the service triplet is require…
7db3c50 
…d to be unique by semantic conventions (open-telemetry#3945)

Fixes
open-telemetry#3944

OTLP does not include that requirement.

Co-authored-by: jack-berg <34418638+jack-berg@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yurishkuro yurishkuro

Labels
spec:metrics Related to the specification/metrics directory
Projects
None yet
Milestone
No milestone
3 participants
@dashpole @yurishkuro @tigrannajaryan