Change Status to be consistent with Link and Event #1067
Merged
+43
−68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu
commented
Oct 6, 2020
| Sets the [`Status`](#status) of the `Span`. If used, this will override the | ||
| default `Span` status, which is `OK`. | ||
| Sets the `Status` of the `Span`. If used, this will override the default `Span` | ||
| status, which is `Unset`. |
There was a problem hiding this comment.
This is fixing a bug in the specs (I guess)
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
yurishkuro
reviewed
Oct 6, 2020
| Application developers and Operators may set the status code to `Ok`. | ||
|
|
||
| Analysis tools SHOULD respond to an `Ok` status by suppressing any errors they | ||
| would otherwise generate. For example, to suppress noisy errors such as 404s. |
There was a problem hiding this comment.
Not following - why would analysis tools generate errors?
There was a problem hiding this comment.
Good question, I was not changing this, will file the issue #1068 to track this.
specification/trace/api.md
Outdated
| to ignore previous calls. | ||
| `Status` is semantically defined by the following properties: | ||
|
|
||
| - `StatusCanonicalCode` represents the canonical set of `Status` codes. |
There was a problem hiding this comment.
Why are we using such a long name as StatusCanonicalCode? Are there non-canonical status codes?
There was a problem hiding this comment.
Good question, I was not changing this, will file the issue #1069 to track this.
Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com>
Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com>
This was referenced Oct 6, 2020
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu
added
area:api
tigrannajaryan
approved these changes
Oct 6, 2020
carlosalberto
approved these changes
Oct 7, 2020
iNikem
approved these changes
Oct 7, 2020
anuraaga
approved these changes
Oct 7, 2020
arminru
approved these changes
Oct 7, 2020
Comment on lines
+536
to
+537
| Only the value of the last call will be recorded, and implementations are free | ||
| to ignore previous calls. |
There was a problem hiding this comment.
This is only taken over but could be refined to be worded consistently (MUST/SHOULD/MAY) either here or in a follow-up.
arminru
reviewed
Oct 7, 2020
Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Bogdan Drutu bogdandrutu@gmail.com
Fixes #1037
Fixes #1040