Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "canonical" adjective from Status Code #1081

Merged

Conversation

tigrannajaryan
Copy link
Member

Resolves: #1069

specification/trace/api.md Outdated Show resolved Hide resolved
specification/trace/api.md Outdated Show resolved Hide resolved
@tigrannajaryan tigrannajaryan force-pushed the feature/tigran/status-code branch 2 times, most recently from 6e7bf74 to a64d3cb Compare October 9, 2020 13:22
specification/trace/api.md Outdated Show resolved Hide resolved
specification/trace/api.md Outdated Show resolved Hide resolved
@arminru
Copy link
Member

arminru commented Oct 9, 2020

Please add an entry in the changelog and preferably a spec compliance matrix entry to keep track of the renamings for GA.

Copy link
Member

@arminru arminru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tigrannajaryan Please consider applying the suggested changes, StatusCode seems to be the preferred name as per the 👍s and would also solve the issue you mentioned in open-telemetry/opentelemetry-proto#224 (comment).

specification/trace/api.md Outdated Show resolved Hide resolved
specification/trace/api.md Outdated Show resolved Hide resolved
specification/trace/api.md Outdated Show resolved Hide resolved
@tigrannajaryan
Copy link
Member Author

Please add an entry in the changelog and preferably a spec compliance matrix entry to keep track of the renamings for GA.

Changelog entry added. Spec compliance matrix does not require changes since it refers to simply "status".

@arminru
Copy link
Member

arminru commented Oct 14, 2020

Changelog entry added. Spec compliance matrix does not require changes since it refers to simply "status".

I thought of a separate entry for keeping track of SIGs adopting the renaming before releasing them as RC/GA.

@tigrannajaryan
Copy link
Member Author

Changelog entry added. Spec compliance matrix does not require changes since it refers to simply "status".

I thought of a separate entry for keeping track of SIGs adopting the renaming before releasing them as RC/GA.

I think that is what changelog is intended for. Maintainers need to check the changelog to know what they may need to change in the implementation.

@arminru
Copy link
Member

arminru commented Oct 14, 2020

Changelog entry added. Spec compliance matrix does not require changes since it refers to simply "status".

I thought of a separate entry for keeping track of SIGs adopting the renaming before releasing them as RC/GA.

I think that is what changelog is intended for. Maintainers need to check the changelog to know what they may need to change in the implementation.

Yes, that's how maintainers are notified about the change, but the GC/TC will look at the spec compliance matrix to determine whether an implementation fulfills the spec requirements for RC/GA - at least that's my understanding.

@arminru arminru requested a review from a team October 14, 2020 15:19
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Why are we using such a long name as StatusCanonicalCode?
7 participants