Add OpenMetrics guidance #1154
Merged
Add OpenMetrics guidance #1154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinfoote
force-pushed
the
openmetrics_guidance
branch
from
73c564c
to
be2674a
Compare
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
|
@jmacd ptal |
MrAlias
approved these changes
Nov 11, 2020
jmacd
approved these changes
Nov 12, 2020
SergeyKanzhelev
approved these changes
Nov 17, 2020
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #600
This PR adds some guidelines for interoperating with OpenMetrics systems.
I have not fully specified the behavior of accepting OpenMetrics metrics -- I've delegated that to the existing design document in the collector's prometheus receiver. I am making the assumption that this is the only place we expect to accept OpenMetrics data into OpenTelemetry, and that their design document is sufficient for now.
I have included guidelines about metric and label renaming when converting OpenTelemetry metrics to OpenMetrics.
I have not included details about the values, or about how many OpenMetrics metrics should be created for each OpenTelemetry aggregation type. I'd love to chat more about the details here before it gets written up.
Changes