-
Notifications
You must be signed in to change notification settings - Fork 886
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OTEL_TRACE_SAMPLER_ARG env variable definition. #1202
Add OTEL_TRACE_SAMPLER_ARG env variable definition. #1202
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@open-telemetry/specs-approvers Please review this issue (will merge by EOD Monday). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice solution!
Co-authored-by: Christian Neumüller <christian+github@neumueller.me>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just one minor comment left.
Co-authored-by: Tigran Najaryan <4194920+tigrannajaryan@users.noreply.github.com>
Fixes #1105
Closes #1190 (alternative solution)
Changes
It was discussed in the latest TC meeting trying out the approach taken by Jaeger, which uses two environment variables to configure samplers:
This way, each
Sampler
will use the same environment variable, and we could even extend the future expected input, i.e. accept json.