Remove ordering reqirement for attributes. #1212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oberon00
changed the title
Oberon00
added
area:api
iNikem
approved these changes
Nov 9, 2020
trask
approved these changes
Nov 9, 2020
bogdandrutu
approved these changes
Nov 9, 2020
tigrannajaryan
approved these changes
Nov 9, 2020
anuraaga
approved these changes
Nov 10, 2020
arminru
approved these changes
Nov 10, 2020
carlosalberto
approved these changes
Nov 10, 2020
|
8 approves (6 from owners) |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1203
Changes
Removes ordering requirement for attributes for now.
Motivation
If we decide this is helpful, we can add it back after GA. But if we have it in GA and decide it is not worth it (e.g. for performance reasons), removing this would be a potentially breaking change for users.
CC @jkwatson